Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds external webbing vest to the IO's vendor as an alternative to the service jacket #4963

Closed
wants to merge 10 commits into from

Conversation

kirieee
Copy link
Contributor

@kirieee kirieee commented Nov 19, 2023

About the pull request

Adds an external webbing vest to the IO vendors.

Explain why it's good for the game

I think that the service jacket looks a little goofy for going into a combat zone, but I want to keep the utility and speed it provides. The external webbing has the same stats, it's just a different (and, in my opinion, better) look than wearing a service jacket into battle.

Testing Photographs and Procedure

Here's some pictures of the onmob and regular sprite:
image
image

Opened game. Webbing was in the vendor. :3

Changelog

🆑
add: External webbing vest added to IO vendors
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Nov 19, 2023
@fira
Copy link
Member

fira commented Nov 19, 2023

But the webbing has no protection while the jacket does - or am I missing something here

@kirieee
Copy link
Contributor Author

kirieee commented Nov 19, 2023

I've just checked. The webbing vest has no protection at all, however the service jacket has LOW protection in melee and bullet. I was under the assumption the stats were the same, but I still don't think that this is much of a problem. I'm somewhat inexperienced when it comes to balance so I might be wrong

@Steelpoint
Copy link
Contributor

The asthetics of external webbing do look far more appealing than the service jacket, but the loss of armour will be a blow and make IOs even more vulnerable to damage if they take this instead of a jacket.

I did toy with the idea of adding a custom-custom external webbing that basically functioned identically to a service jacket but with the external webbing sprites as noted here: #4341

I mostly closed it due to feeling mixed about adding another armour option but if this idea is warranted you could consider something like I did

@kirieee kirieee marked this pull request as draft November 20, 2023 16:57
@kirieee
Copy link
Contributor Author

kirieee commented Nov 20, 2023

I think I'll try editing the external webbing and putting a custom version in, then, just to fully smooth things over. I'm not entirely sure how to make a whole new clothing item like that but I'll figure it out, hopefully with some help

@Steelpoint
Copy link
Contributor

I think I'll try editing the external webbing and putting a custom version in, then, just to fully smooth things over. I'm not entirely sure how to make a whole new clothing item like that but I'll figure it out, hopefully with some help

You can look over how I did it, the PR itself was fine I just ran into unrelated merge conflicts and a disinterest to finish the PR.

@Huffie56
Copy link
Contributor

Huffie56 commented Nov 22, 2023

if your item isn't OP i would suggest you to add it to the clothing surplus vendor instead of just IO vendor...
image

@kirieee
Copy link
Contributor Author

kirieee commented Nov 22, 2023

Adding it to the clothing vendors would essentially be the same as adding a service jacket to the vendors, too. I'm not opposed! But I think that some maintainers would be?

@Huffie56
Copy link
Contributor

Adding it to the clothing vendors would essentially be the same as adding a service jacket to the vendors, too. I'm not opposed! But I think that some maintainers would be?

as long as it's not OP and in small number i don't see a reason to not add them but yes maintainer have to approve it.
maybe just ask them on discord in dev channel?

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Nov 30, 2023
@fira
Copy link
Member

fira commented Dec 1, 2023

Well, marines already get the Service Jacket from Dress Vendors, that's what they're for

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Dec 2, 2023
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 10, 2023
@kirieee kirieee marked this pull request as ready for review December 10, 2023 17:10
@kirieee kirieee closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants